zwoop commented on a change in pull request #6957:
URL: https://github.com/apache/trafficserver/pull/6957#discussion_r446398255
##########
File path: iocore/net/SSLUtils.cc
##########
@@ -1840,6 +1840,7 @@ SSLAccept(SSL *ssl)
if (ret == SSL_READ_EARLY_DATA_ERROR) {
Debug("ssl_early_data", "SSL_READ_EARLY_DATA_ERROR");
+ block->free();
Review comment:
Not sure how that's useful here, but maybe I'm missing something. You
can't free things here when it goes out of scope, and you don't want to let it
sit there if it's not going to be used either. Once used, it'll have to be
freed up later, when it's no longer needed (you are collecting this early data
as part of the handshake, to be used later by the HttpSM).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
