duke8253 commented on pull request #6957:
URL: https://github.com/apache/trafficserver/pull/6957#issuecomment-651286356
> Looking some more, I wonder if we could optimize for the common case
(which is that the client fails to negotiate early data, at least for now).
E.g. move this into inside the while() loop, and after the check if the early
data read succeeded or not:
>
> ```
> if (netvc->early_data_buf == nullptr) {
> netvc->early_data_buf = new_MIOBuffer(BUFFER_SIZE_INDEX_16K);
> netvc->early_data_reader = netvc->early_data_buf->alloc_reader();
> }
> ```
The reason I left it out was to not do the `if` check everytime it loops
around, but I guess this will make it cleaner, and the check doesn't really
take much time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
