shinrich commented on a change in pull request #6919:
URL: https://github.com/apache/trafficserver/pull/6919#discussion_r455332417
##########
File path: plugins/experimental/slice/response.cc
##########
@@ -68,10 +68,13 @@ string502()
bodystr.append("</body>\n");
bodystr.append("</html>\n");
+ char hverstr[64];
+ int const hlen =
+ snprintf(hverstr, sizeof(hverstr), "HTTP/%d.%d 502 Bad Gateway\r\n",
TS_HTTP_MAJOR(httpver), TS_HTTP_MINOR(httpver));
+ msg.append(hverstr, hlen);
+
Review comment:
I assume this is the heart of your 502 fixes for this PR. Much of the
rest looks like more general cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
