traeak commented on a change in pull request #6919:
URL: https://github.com/apache/trafficserver/pull/6919#discussion_r456001411
##########
File path: plugins/experimental/slice/response.cc
##########
@@ -68,10 +68,13 @@ string502()
bodystr.append("</body>\n");
bodystr.append("</html>\n");
+ char hverstr[64];
+ int const hlen =
+ snprintf(hverstr, sizeof(hverstr), "HTTP/%d.%d 502 Bad Gateway\r\n",
TS_HTTP_MAJOR(httpver), TS_HTTP_MINOR(httpver));
+ msg.append(hverstr, hlen);
+
Review comment:
Yes sort of. The original PR was much more aggressive about trying to
use the state machine but attempts failed and this cleanup was what was left
over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
