masaori335 commented on a change in pull request #6978:
URL: https://github.com/apache/trafficserver/pull/6978#discussion_r460591651
##########
File path: proxy/http/HttpSessionManager.cc
##########
@@ -369,6 +370,25 @@ HttpSessionManager::acquire_session(Continuation * /* cont
ATS_UNUSED */, sockad
to_return = nullptr;
}
+ // Otherwise, check the thread pool first
+ if (this->get_pool_type() == TS_SERVER_SESSION_SHARING_POOL_THREAD ||
this->get_hybrid_limit() != 0) {
+ retval = acquire_session(ip, hostname_hash, sm, match_style,
TS_SERVER_SESSION_SHARING_POOL_THREAD);
+ }
+
+ // If you didn't get a match, and the global pool is an option go there.
+ if (retval != HSM_DONE && (TS_SERVER_SESSION_SHARING_POOL_GLOBAL ==
this->get_pool_type())) {
+ retval = acquire_session(ip, hostname_hash, sm, match_style,
TS_SERVER_SESSION_SHARING_POOL_GLOBAL);
+ }
+ return retval;
+}
+
+HSMresult_t
+HttpSessionManager::acquire_session(sockaddr const *ip, CryptoHash const
&hostname_hash, HttpSM *sm,
Review comment:
Could you rename like `_acquire_session()` or something else? Having
public and private functions in the same name looks confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
