shinrich commented on a change in pull request #6978:
URL: https://github.com/apache/trafficserver/pull/6978#discussion_r518913271



##########
File path: proxy/http/HttpSessionManager.cc
##########
@@ -446,6 +466,10 @@ HttpSessionManager::release_session(Http1ServerSession 
*to_release)
   MUTEX_TRY_LOCK(lock, pool->mutex, ethread);
   if (lock.is_locked()) {

Review comment:
       I did try the reschedule a few years back.  It didn't help things 
because our global pool is already heavily contended.  Adding retries just adds 
to the contention.  Even for this PR, I tried a version that attempted to put 
the sessions back into the global pool on the next use even if we had 
temporarily put them in the thread pool.  Just that change increased number of 
connections to origin and reduced connection reuse.  I can give the reschedule 
another attempt, but probably not until January.  I'm heads down in other 
issues for the rest of the quarter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to