ywkaras commented on a change in pull request #7262:
URL: https://github.com/apache/trafficserver/pull/7262#discussion_r501978141
##########
File path: tests/tools/plugins/test_tsapi.cc
##########
@@ -28,14 +28,6 @@ Regression testing code for TS API. Not comprehensive,
hopefully will be built
#include <ts/ts.h>
#include <tscpp/util/PostScript.h>
-// TSReleaseAssert() doesn't seem to produce any logging output for a debug
build, so do both kinds of assert.
-//
-#define ALWAYS_ASSERT(EXPR) \
- { \
- TSAssert(EXPR); \
- TSReleaseAssert(EXPR); \
- }
-
Review comment:
Some unrelated cleanup, included in this PR.
##########
File path: tests/gold_tests/pluginTest/tsapi/log.gold
##########
@@ -1,14 +1,87 @@
Global: event=TS_EVENT_HTTP_TXN_START
Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
TSHttpTxnEffectiveUrlStringGet(): http://mYhOsT.teSt:SERVER_PORT/
+Client Request:
TSHttpHdrEffectiveUrlBufGet(): http://myhost.test:SERVER_PORT/
+TSUrlSchemeGet(): http
+TSUrlRawSchemeGet(): http
+TSUrlPortGet(): 80
Transaction: event=TS_EVENT_HTTP_READ_REQUEST_HDR
TSHttpTxnEffectiveUrlStringGet(): http://mYhOsT.teSt:SERVER_PORT/
+Client Request:
TSHttpHdrEffectiveUrlBufGet(): http://myhost.test:SERVER_PORT/
+TSUrlSchemeGet(): http
+TSUrlRawSchemeGet(): http
+TSUrlPortGet(): 80
+Global: event=TS_EVENT_HTTP_SEND_REQUEST_HDR
+TSHttpTxnEffectiveUrlStringGet(): http://127.0.0.1:SERVER_PORT/
+Request To Server:
+TSHttpHdrEffectiveUrlBufGet(): 127.0.0.1:SERVER_PORT/
Review comment:
This should be fixed in a future PR. Should include the implicit scheme.
##########
File path: tests/gold_tests/pluginTest/tsapi/log.gold
##########
@@ -1,14 +1,87 @@
Global: event=TS_EVENT_HTTP_TXN_START
Global: event=TS_EVENT_HTTP_READ_REQUEST_HDR
TSHttpTxnEffectiveUrlStringGet(): http://mYhOsT.teSt:SERVER_PORT/
+Client Request:
TSHttpHdrEffectiveUrlBufGet(): http://myhost.test:SERVER_PORT/
+TSUrlSchemeGet(): http
+TSUrlRawSchemeGet(): http
+TSUrlPortGet(): 80
Review comment:
This should return SERVER_PORT, to be fixed in future PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
