maskit commented on a change in pull request #7262:
URL: https://github.com/apache/trafficserver/pull/7262#discussion_r508914961
##########
File path: tests/gold_tests/pluginTest/tsapi/tsapi.test.py
##########
@@ -71,7 +71,15 @@
tr.Processes.Default.StartBefore(Test.Processes.ts)
#
tr.Processes.Default.Command = (
- 'curl --verbose --ipv4 --header "Host: mYhOsT.teSt:{0}"
hTtP://loCalhOst:{1}/'.format(server.Variables.Port, ts.Variables.port)
+ r'printf "GET / HTTP/1.1\r\nHost: mYhOsT.teSt:{0}\r\n\r\n" | nc localhost
{1}'.format(
Review comment:
I prefer consistently using curl for all HTTP versions as long as curl
can do the same thing, because I can clearly see the tests do the same things
on different versions.
If you think we all should use printf and nc for H1 test cases, you should
make another PR to make the change for all H1 tests, and let's see what other
people think. I don't think this change has to be done on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
