rob05c commented on a change in pull request #7276:
URL: https://github.com/apache/trafficserver/pull/7276#discussion_r512749772
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -1856,12 +1852,9 @@ HttpTransact::ReDNSRoundRobin(State *s)
void
HttpTransact::OSDNSLookup(State *s)
{
- static const int max_dns_lookups = 3;
-
ink_assert(s->dns_info.looking_up == ORIGIN_SERVER);
- TxnDebug("http_trans", "[HttpTransact::OSDNSLookup] This was attempt %d",
s->dns_info.attempts);
Review comment:
I was mostly worried about debugging loops. I said transaction, I meant
host. It sounds like it shouldn't get called for the same host repeatedly, and
if it is, if there is a loop, there should be other debug messages. Besides
which, I think parent selection is the right place to log "this is lookup N"
not here.
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -1856,12 +1852,9 @@ HttpTransact::ReDNSRoundRobin(State *s)
void
HttpTransact::OSDNSLookup(State *s)
{
- static const int max_dns_lookups = 3;
-
ink_assert(s->dns_info.looking_up == ORIGIN_SERVER);
- TxnDebug("http_trans", "[HttpTransact::OSDNSLookup] This was attempt %d",
s->dns_info.attempts);
Review comment:
I was mostly worried about debugging loops. I said transaction, I meant
host. It sounds like it shouldn't get called for the same host repeatedly, and
if it is, if there is a loop, there should be other debug messages. Besides
which, I think parent selection is the right place to log "this is lookup N,"
not here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
