rob05c commented on a change in pull request #7276:
URL: https://github.com/apache/trafficserver/pull/7276#discussion_r512781357
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -6564,28 +6511,6 @@ HttpTransact::process_quick_http_filter(State *s, int
method)
}
}
-HttpTransact::HostNameExpansionError_t
-HttpTransact::try_to_expand_host_name(State *s)
-{
- HTTP_RELEASE_ASSERT(!s->dns_info.lookup_success);
-
- if (s->dns_info.looking_up == ORIGIN_SERVER) {
- return EXPANSION_NOT_ALLOWED;
- } else {
- //////////////////////////////////////////////////////
- // we looked up dns of parent proxy, but it failed, //
- // try lookup of origin server name. //
- //////////////////////////////////////////////////////
- ink_assert(s->dns_info.looking_up == PARENT_PROXY);
-
- s->dns_info.lookup_name = s->server_info.name;
- s->dns_info.looking_up = ORIGIN_SERVER;
Review comment:
Oh, there is a functional change here: if the parent DNS lookup failed,
we used to covertly get and return the Origin IP, when the Parent Selection
asked for the Parent? Wat? That seems always wrong.
My Approval stands: if this was happening, I think it was wrong. Returning
an IP for a host Parent Selection didn't ask for sounds like it would cause all
kinds of confusion and unexpected behavior. If we need to fail to the Origin,
Parent Selection (/Nexthop/Strategies) needs to decide that, not the DNS lookup
subversively returning an IP for a host we didn't ask for.
Can someone else confirm that? @jrushford
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
