masaori335 commented on a change in pull request #7401:
URL: https://github.com/apache/trafficserver/pull/7401#discussion_r546531797
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -4464,7 +4464,7 @@
HttpTransact::handle_cache_operation_on_forward_server_response(State *s)
// before issuing a 304
if (s->cache_info.action == CACHE_DO_WRITE || s->cache_info.action ==
CACHE_DO_NO_ACTION ||
s->cache_info.action == CACHE_DO_REPLACE) {
- if (s->is_cacheable_and_negative_caching_is_enabled) {
+ if (s->is_cacheable_and_negative_caching_is_enabled &&
is_negative_caching_appropriate(s)) {
Review comment:
FWIW, this change ~~fixed~~ hide a leak which I reported on
https://github.com/apache/trafficserver/issues/7380#issuecomment-748701998.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
