bneradt commented on a change in pull request #7401:
URL: https://github.com/apache/trafficserver/pull/7401#discussion_r547561420
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -4464,7 +4464,7 @@
HttpTransact::handle_cache_operation_on_forward_server_response(State *s)
// before issuing a 304
if (s->cache_info.action == CACHE_DO_WRITE || s->cache_info.action ==
CACHE_DO_NO_ACTION ||
s->cache_info.action == CACHE_DO_REPLACE) {
- if (s->is_cacheable_and_negative_caching_is_enabled) {
+ if (s->is_cacheable_and_negative_caching_is_enabled &&
is_negative_caching_appropriate(s)) {
Review comment:
Great! Thank you @masaori335 for the quick confirmation. I also ran the
negative-caching AuTest with this change on master and verified that the
original negative caching fix still works as expected.
@shinya1020 : Can you please try out this change on your branch and verify
it addresses the Expires header issue you were seeing? If so, I suggest we
update this PR and get this merged in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
