masaori335 commented on a change in pull request #7422:
URL: https://github.com/apache/trafficserver/pull/7422#discussion_r559353218
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -5905,6 +5906,12 @@ HttpTransact::is_stale_cache_response_returnable(State
*s)
if (!s->cache_info.directives.does_client_permit_lookup) {
return false;
}
+ // We don't serve a stale negative cache.
Review comment:
This might have a pretty big impact in other places where calls this
function.
@sudheerv Is this change safe with
`CACHE_WL_FAIL_ACTION_STALE_ON_REVALIDATE`?
https://github.com/apache/trafficserver/blob/690ec54950611a1955b34911b73a222365998667/proxy/http/HttpTransact.cc#L7215-L7216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
