masaori335 commented on a change in pull request #7422:
URL: https://github.com/apache/trafficserver/pull/7422#discussion_r563508778
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -5905,6 +5906,12 @@ HttpTransact::is_stale_cache_response_returnable(State
*s)
if (!s->cache_info.directives.does_client_permit_lookup) {
return false;
}
+ // We don't serve a stale negative cache.
Review comment:
@fdiary How about move this change under the if-block of doing negative
revalidating to minimize side effects?
https://github.com/apache/trafficserver/blob/b6b61fbd3e232dbef010dc8b712bb2076510bd7f/proxy/http/HttpTransact.cc#L4347
My concern is this changes behavior of setting `2` and `3` of
`proxy.config.http.cache.open_write_fail_action`[*1]. It's a config to do
stale-while-revalidate, so if we never serve negative stale cache, all
simultaneous requests might go to the origin server.
[*1]
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-open-write-fail-action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
