duke8253 commented on a change in pull request #7479:
URL: https://github.com/apache/trafficserver/pull/7479#discussion_r572229063



##########
File path: iocore/net/SSLSessionCache.h
##########
@@ -198,3 +201,19 @@ class SSLSessionCache
   SSLSessionBucket *session_bucket = nullptr;
   size_t nbuckets;
 };
+
+class SSLOriginSessionCache
+{
+public:
+  SSLOriginSessionCache();
+  ~SSLOriginSessionCache();
+
+  void insertSession(std::string lookup_key, SSL_SESSION *sess);
+  SSL_SESSION *getSession(std::string lookup_key);
+
+private:
+  mutable std::shared_mutex mutex;

Review comment:
       Well, since the server side session cache has proven that using 
`std::shared_mutex` is beneficial, I thought it should be used here as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to