duke8253 commented on pull request #7479:
URL: https://github.com/apache/trafficserver/pull/7479#issuecomment-777934115


   > Should we have a setting value for OpenSSL impl? If we added it later, the 
value for it would be `2`, which would be confusing because `2` means ATS impl 
for client session cache.
   > 
   > Is there any reason for disabling this by default? The one for client 
session cache is enabled by default and it uses ATS impl.
   > 
   > We might need to call `SSL_CTX_sess_set_remove_cb()` as well. I'm not 
sure. OpenSSL API doc says it's for internal cache, but we set a callback for 
client session cache when we use ATS impl.
   > 
   > Please add docs for the new settings.
   
   Yeah, I'll add docs for this tomorrow. About the configs, I thought about 
adding the config to use openssl's internal cache, it should be really easy 
change. As for the other `cb` functions, it's easy to implement, can add those 
in as well, though the documentation is really vague on whether they're used 
here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to