SolidWallOfCode commented on a change in pull request #7467:
URL: https://github.com/apache/trafficserver/pull/7467#discussion_r576944218
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -178,12 +178,22 @@ inline static void
findParent(HttpTransact::State *s)
{
url_mapping *mp = s->url_map.getMapping();
-
- if (mp && mp->strategy) {
- return
mp->strategy->findNextHop(reinterpret_cast<TSHttpTxn>(s->state_machine));
+ if (s->response_action.handled) {
+ s->parent_result.hostname = s->response_action.action.hostname;
+ s->parent_result.port = s->response_action.action.port;
+ s->parent_result.retry = s->response_action.action.retry;
Review comment:
I don't understand this value. Shouldn't the core determine / know if
it's a retry? The plugin shouldn't be the authority on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
