rob05c commented on a change in pull request #7467:
URL: https://github.com/apache/trafficserver/pull/7467#discussion_r576991520
##########
File path: proxy/http/HttpTransact.cc
##########
@@ -178,12 +178,22 @@ inline static void
findParent(HttpTransact::State *s)
{
url_mapping *mp = s->url_map.getMapping();
-
- if (mp && mp->strategy) {
- return
mp->strategy->findNextHop(reinterpret_cast<TSHttpTxn>(s->state_machine));
+ if (s->response_action.handled) {
+ s->parent_result.hostname = s->response_action.action.hostname;
+ s->parent_result.port = s->response_action.action.port;
+ s->parent_result.retry = s->response_action.action.retry;
Review comment:
The plugin needs to know, for markdown and other things. The core does
know, it's tracked in `parent_result.retry`. I guess we could add code to set
that independent of the `response_action`, but that code doesn't exist today,
it was previously in the old parent path that's not taken for
response_action/strategy. I'm not sure exactly where it'd have to be added.
I'm also not 100% sure there isn't a use case where a plugin would want to
set retry=false even though it is, to elicit certain behavior. It seems
strange, but I'm not certain it isn't valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
