dragon512 commented on a change in pull request #7668:
URL: https://github.com/apache/trafficserver/pull/7668#discussion_r605925463
##########
File path: tests/gold_tests/pluginTest/combo_handler/combo_handler.test.py
##########
@@ -104,12 +106,12 @@ def add_server_obj(content_type, path):
'map http://localhost/sub/
http://127.0.0.1:{}/sub/'.format(server.Variables.Port)
)
-ts.Disk.File(ts.Variables.CONFIGDIR + "/ctwl.txt", id="ctwl_cfg",
typename="ats:config")
-ts.Disk.ctwl_cfg.AddLine("# test ")
-ts.Disk.ctwl_cfg.AddLine("")
-ts.Disk.ctwl_cfg.AddLine(" text/javascript # test side comment")
-ts.Disk.ctwl_cfg.AddLine(" application/javascript")
-ts.Disk.ctwl_cfg.AddLine("text/css")
+# Configure the combo_handler's configuration file.
+ts.Setup.Copy("ctwl.txt", ts.Variables.CONFIGDIR)
+ctwl_cfg_path = os.path.join(ts.Variables.CONFIGDIR, "ctwl.txt")
+ts.Setup.Chown(ctwl_cfg_path, "nobody", "nobody", ignore=True)
+# covers ubuntu's unprivileged group
+ts.Setup.Chown(ctwl_cfg_path, "nobody", "nogroup", ignore=True)
Review comment:
I am a little worried about this as we found issues where nobody or
nogroup causes errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
