dragon512 commented on a change in pull request #7668:
URL: https://github.com/apache/trafficserver/pull/7668#discussion_r605929283
##########
File path: tests/gold_tests/pluginTest/url_sig/url_sig.test.py
##########
@@ -63,30 +63,31 @@
# Use unchanged incoming URL.
#
+ts.Setup.Copy("url_sig.config", ts.Variables.CONFIGDIR)
ts.Disk.remap_config.AddLine(
'map http://one.two.three/
http://127.0.0.1:{}/'.format(server.Variables.Port) +
- ' @plugin=url_sig.so @pparam={}/url_sig.config'.format(Test.TestDirectory)
Review comment:
just a general note... This could be clean up more via saying
`f'map http://one.two.three/ http://127.0.0.1:{server.Variables.Port}/' +`
This can be done to a number of cases below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
