maskit commented on a change in pull request #7708:
URL: https://github.com/apache/trafficserver/pull/7708#discussion_r613649688
##########
File path: plugins/experimental/parent_select/consistenthash_config.cc
##########
@@ -187,8 +187,8 @@ loadConfigFile(const std::string fileName,
std::stringstream &doc, std::unordere
std::sort(files.begin(), files.end(),
[](const std::string_view lhs, const std::string_view rhs) {
return lhs.compare(rhs) < 0; });
- for (uint32_t i = 0; i < files.size(); i++) {
- std::ifstream file(fileName + "/" + files[i].data());
+ for (auto &i : files) {
Review comment:
nitpick: `f` would make more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
