bneradt commented on a change in pull request #7708:
URL: https://github.com/apache/trafficserver/pull/7708#discussion_r615097818
##########
File path: plugins/experimental/parent_select/consistenthash_config.cc
##########
@@ -108,8 +108,8 @@ createStrategiesFromFile(const char *file)
// std::map<std::string, TSNextHopSelectionStrategy*, std::less<>>
strategies_map strategiesMap;
- for (unsigned int i = 0; i < strategies.size(); ++i) {
- YAML::Node strategy = strategies[i];
+ for (auto &&strategie : strategies) {
+ YAML::Node strategy = strategie;
Review comment:
There were two `strategie` variables in the diff. The second is address,
but this remains.
Look out though: renaming this to strategy will also clash with the inner
`strategy` variable. We can potentially change `strategie` to `strategy`, and
the inner strategy to `strategy_copy`?
Thanks for working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
