sudheerv commented on a change in pull request #7768:
URL: https://github.com/apache/trafficserver/pull/7768#discussion_r625402107



##########
File path: proxy/http/remap/RemapConfig.cc
##########
@@ -949,7 +949,7 @@ remap_parse_config_bti(const char *path, BUILD_TABLE_INFO 
*bti)
     switch (ec.value()) {
     case ENOENT:
       Warning("Can't open remapping configuration file %s - %s", path, 
strerror(ec.value()));
-      break;
+      return true;

Review comment:
       I had `false` earlier but, that fails some autest that seems to expect 
true for a non-existent file.
   
   https://ci.trafficserver.apache.org/job/autest-github/15470/console
   
   
   {code}
   file 
/var/tmp/ausb-7768.15470/thread_config/ts-1_exec-0_accept-1_task-1_aio/log/diags.log
 : diags.log should not contain errors - Failed
           Reason: Contents of 
/var/tmp/ausb-7768.15470/thread_config/ts-1_exec-0_accept-1_task-1_aio/log/diags.log
 contains expression: "FATAL:"
              Details:
                [Apr 30 11:29:45.164] traffic_server FATAL: remap.config failed 
to load : 34
   {code}




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to