SolidWallOfCode commented on pull request #7768:
URL: https://github.com/apache/trafficserver/pull/7768#issuecomment-832121595


   Thinking more deeply on this and after a discussion with @sudheerv, I think 
the approach would be
   
   *  Remove the check on `UrlRewrite::load` from `init_reverse_proxy`.
   *  Change `UrlRewrite::load` to generate a `Warning` and fail on any failure 
to load "remap.config".
   
   This would change startup behavior such that a missing "remap.config" would 
not prevent startup. As we've wanted to move toward fewer required files, I 
think this is a feature, not a bug. It would be consistent with the more 
general rule that has been adopted to treat a missing file as if it were an 
empty file. This would be detected (if the missing file is actually a problem) 
by 404 responses and the `Warning` in "diags.log". 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to