sudheerv commented on a change in pull request #7782:
URL: https://github.com/apache/trafficserver/pull/7782#discussion_r626130874
##########
File path: proxy/ReverseProxy.cc
##########
@@ -67,7 +67,8 @@ init_reverse_proxy()
Note("%s loading ...", ts::filename::REMAP);
if (!rewrite_table->load()) {
- Fatal("%s failed to load", ts::filename::REMAP);
+ Warning("%s failed to load", ts::filename::REMAP);
+ return 0;
Review comment:
But, the code and the configs that are being added past this if check
all seem to be somehow related to remaps though?
>> Note there should be nothing to prevent adding a valid "remap.config"
file after process start. It's just another variant of reloading.
I'd say this is more of what we _want_ to support though. It seems
reasonable that we'd only enable remap reloads, if there was a valid remap
during start up.
``` REC_RegisterConfigUpdateFunc("proxy.config.url_remap.filename",
url_rewrite_CB, (void *)FILE_CHANGED);
REC_RegisterConfigUpdateFunc("proxy.config.proxy_name", url_rewrite_CB,
(void *)TSNAME_CHANGED);
REC_RegisterConfigUpdateFunc("proxy.config.reverse_proxy.enabled",
url_rewrite_CB, (void *)REVERSE_CHANGED);
REC_RegisterConfigUpdateFunc("proxy.config.http.referer_default_redirect",
url_rewrite_CB, (void *)HTTP_DEFAULT_REDIRECT_CHANGED);
// Hold at least one lease, until we reload the configuration
rewrite_table->acquire();```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
