SolidWallOfCode commented on a change in pull request #7782:
URL: https://github.com/apache/trafficserver/pull/7782#discussion_r626139829
##########
File path: proxy/ReverseProxy.cc
##########
@@ -67,7 +67,8 @@ init_reverse_proxy()
Note("%s loading ...", ts::filename::REMAP);
if (!rewrite_table->load()) {
- Fatal("%s failed to load", ts::filename::REMAP);
+ Warning("%s failed to load", ts::filename::REMAP);
+ return 0;
Review comment:
Related, but not the same.
> It seems reasonable that we'd only enable remap reloads, if there was a
valid remap during start up.
I strongly disagree with that, as it means we can't do discovery to pull in
"remap.config", which is something we're looking at with regard to
containerization of ATS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
