maskit commented on a change in pull request #7622:
URL: https://github.com/apache/trafficserver/pull/7622#discussion_r630806172
##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -4934,12 +4934,11 @@ TSHttpSsnClientVConnGet(TSHttpSsn ssnp)
TSVConn
TSHttpSsnServerVConnGet(TSHttpSsn ssnp)
{
- TSVConn vconn = nullptr;
PoolableSession *ss = reinterpret_cast<PoolableSession *>(ssnp);
if (ss != nullptr) {
- vconn = reinterpret_cast<TSVConn>(ss->get_netvc());
+ return reinterpret_cast<TSVConn>(ss->get_netvc());
Review comment:
This is unnecessary for H2 to Origin, and inconsistent with a similar
code in `TSHttpTxnServerVConnGet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
