maskit commented on a change in pull request #7622:
URL: https://github.com/apache/trafficserver/pull/7622#discussion_r630838877
##########
File path: proxy/ProxySession.h
##########
@@ -156,6 +156,12 @@ class ProxySession : public VConnection, public
PluginUserArgs<TS_USER_ARGS_SSN>
void do_io_shutdown(ShutdownHowTo_t howto) override;
void reenable(VIO *vio) override;
+ virtual ProxyTransaction *
Review comment:
I'm not sure if this is a good default implementation. What does
returning `nullptr` mean?
It could be:
1. The session cannot make a new transaction at the moment due to some
limitation (e.g. H2ServerSession)
2. You are supposed to not call this function for the session (e.g.
H2ClientSession)
For 1, we may want to retry later.
For 2, we may want to abort (assert), because it's a logic error.
And it seems like there's no error handling for case 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
