ywkaras commented on a change in pull request #7606:
URL: https://github.com/apache/trafficserver/pull/7606#discussion_r633717132



##########
File path: proxy/ControlBase.cc
##########
@@ -114,19 +113,19 @@ TimeMod::check(HttpRequestData *req) const
 TimeMod *
 TimeMod::make(char *value, const char **error)
 {
-  Tokenizer rangeTok("-");

Review comment:
       It's not clear to me how to split this PR, without error-prone merge 
conflicts when merging the second PR.  It adds about 100 lines of new code.  Is 
that too big?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to