masaori335 commented on a change in pull request #7606:
URL: https://github.com/apache/trafficserver/pull/7606#discussion_r634855390



##########
File path: proxy/ControlBase.cc
##########
@@ -114,19 +113,19 @@ TimeMod::check(HttpRequestData *req) const
 TimeMod *
 TimeMod::make(char *value, const char **error)
 {
-  Tokenizer rangeTok("-");

Review comment:
       @SolidWallOfCode I'm not a big fan of getting rid of Tokenizer in *this* 
PR. I agree with it's a good change for performance. But it should be done by 
another PR after this PR is merged, IMO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to