masaori335 commented on a change in pull request #7923:
URL: https://github.com/apache/trafficserver/pull/7923#discussion_r647024880



##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -336,7 +330,12 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, 
EThread *thread)
         return;
       }
     }
+  } else if (vc->has_error()) {

Review comment:
       I concern this raise `VC_EVENT_ERROR` in unexpected timing like
   - the reading buffer is full (`toread == 0`)
   - the peer sent all data and reset the connection




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to