shinrich commented on a change in pull request #7923:
URL: https://github.com/apache/trafficserver/pull/7923#discussion_r647025027
##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -336,7 +330,12 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
return;
}
}
+ } else if (vc->has_error()) {
Review comment:
Hmm. The intent was to issue the read error if the reading had not
otherwise hit an error, but that is not what we're doing here. You are correct.
Probably best to remove the error sending on the read side, but leave it on
the write side (from the original) PR. I'll updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
