maskit commented on a change in pull request #8014:
URL: https://github.com/apache/trafficserver/pull/8014#discussion_r662151954
##########
File path: configure.ac
##########
@@ -1276,9 +1279,15 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include
<openssl/ssl.h>]],
AC_MSG_RESULT([no])
])
+AC_ARG_ENABLE([quic],
+ AS_HELP_STRING([--disable-quic], [disable QUIC support]), [
Review comment:
I'm purely curious why the option is needed, and I still don't get the
problem... maybe because I don't use Xcode, but if it's helpful for some
situations I don't against adding it as long as you are not making changes that
are incompatible with QUIC support (having QUIC support as todo is fine).
I'd make another PR for this compile time option so that people can easily
cherrypick the change for their branch.
Current expected behavior of the configure script is to enable QUIC support
whenever SSL library supports QUIC. In other words, the files should not be
part of the build if the library doesn't support QUIC even if you use BoringSSL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
