shinrich commented on a change in pull request #8014:
URL: https://github.com/apache/trafficserver/pull/8014#discussion_r668288607
##########
File path: iocore/net/SSLUtils.cc
##########
@@ -412,12 +424,48 @@ ssl_client_hello_callback(SSL *s, int *al, void *arg)
}
#endif
+#ifdef OPENSSL_IS_BORINGSSL
+static ssl_select_cert_result_t
+ssl_client_hello_callback(const SSL_CLIENT_HELLO *client_hello)
Review comment:
Maybe you want a different name for the BORINGSSL version of this
function, which is really a utility function for the callback instead of the
proper callback. Took me a few minutes looking around to resolve in my head
that the boring version of the function and openssl version with the same name
weren't going to conflict with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
