jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r647656261
##########
File path: iocore/utils/Machine.cc
##########
@@ -219,6 +221,9 @@ Machine::Machine(char const *the_hostname, sockaddr const
*addr)
hostname = ats_strdup(localhost);
}
}
+ if (const char *test_local_host = std::getenv("TS_TEST_LOCALHOST");
test_local_host) {
Review comment:
For discussion: Instead of this, perhaps we should add a boolean in
strategies.yaml say, **is_self: true/false**, that is part of the host
definition. **is_self** is an optional field that defaults to **false**?
##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -63,6 +63,8 @@ bool
NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
{
NH_Debug(NH_DEBUG_TAG, "calling Init()");
+ std::string self_host;
Review comment:
@ywkaras Consider adding this new field to the unit testing, see
proxy/remap/http/unit-tests/test_NextHopConsistentHash.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
