jrushford commented on a change in pull request #7925:
URL: https://github.com/apache/trafficserver/pull/7925#discussion_r669890422



##########
File path: proxy/http/remap/NextHopSelectionStrategy.cc
##########
@@ -63,6 +63,8 @@ bool
 NextHopSelectionStrategy::Init(ts::Yaml::Map &n)
 {
   NH_Debug(NH_DEBUG_TAG, "calling Init()");
+  std::string self_host;

Review comment:
       @ywkaras Consider adding this new field to the unit testing, see 
proxy/remap/http/unit-tests/test_NextHopConsistentHash.cc and 
peering-group.yaml in the same unit-tests directory.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to