ywkaras commented on a change in pull request #8098:
URL: https://github.com/apache/trafficserver/pull/8098#discussion_r674339701
##########
File path: proxy/http/remap/NextHopConsistentHash.cc
##########
@@ -326,6 +326,7 @@ NextHopConsistentHash::findNextHop(TSHttpTxn txnp, void
*ih, time_t now)
// check if the host is retryable. It's retryable if the retry window
has elapsed
_now == 0 ? _now = time(nullptr) : _now = now;
if ((pRec->failedAt.load() + retry_time) <
static_cast<unsigned>(_now)) {
+ NH_Debug(NH_DEBUG_TAG, "[%" PRIu64 "] next hop %s, retriers: %d",
sm_id, pRec->hostname.c_str(), pRec->retriers.load());
Review comment:
For example suppose retriers == max_retriers - 1. Then:
1. one core executes line 330, making retriers == max_retriers, so it goes
to the else clause.
2. another core executes line 330, making retriers == max_retriers + 1, so
it also goes to the else clause.
Both cores will then execute line 341, making retriers == max_retriers - 1
again. But neither one acted as a retrier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
