ywkaras commented on a change in pull request #8098:
URL: https://github.com/apache/trafficserver/pull/8098#discussion_r678550893
##########
File path: proxy/http/remap/NextHopConsistentHash.cc
##########
@@ -326,6 +326,7 @@ NextHopConsistentHash::findNextHop(TSHttpTxn txnp, void
*ih, time_t now)
// check if the host is retryable. It's retryable if the retry window
has elapsed
_now == 0 ? _now = time(nullptr) : _now = now;
if ((pRec->failedAt.load() + retry_time) <
static_cast<unsigned>(_now)) {
+ NH_Debug(NH_DEBUG_TAG, "[%" PRIu64 "] next hop %s, retriers: %d",
sm_id, pRec->hostname.c_str(), pRec->retriers.load());
Review comment:
Is there some way you guarantee the thread interleaving scenario I
describe above can not happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
