bneradt commented on a change in pull request #8279:
URL: https://github.com/apache/trafficserver/pull/8279#discussion_r696035803
##########
File path: plugins/stats_over_http/stats_over_http.c
##########
@@ -1006,8 +1006,8 @@ load_config_file(config_holder_t *config_holder)
}
if (!fh) {
- TSError("[%s] Unable to open config: %s. Will use the param as the path,
or %s if null\n", PLUGIN_NAME,
- config_holder->config_path, DEFAULT_URL_PATH);
+ TSNote("[%s] Unable to open config: %s. Will use the param as the path, or
%s if null\n", PLUGIN_NAME,
+ config_holder->config_path, DEFAULT_URL_PATH);
Review comment:
Just making sure I understand the change: is this being downgraded to
NOTE because this is the message that is emitted when there is no config file
specified? What will happen if the user explicitly provides a config file,
mistypes the path or some such, and the plugin cannot find it? Maybe that
latter case should be an error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
