bneradt commented on a change in pull request #8279:
URL: https://github.com/apache/trafficserver/pull/8279#discussion_r696046656
##########
File path: plugins/stats_over_http/stats_over_http.c
##########
@@ -1006,8 +1006,8 @@ load_config_file(config_holder_t *config_holder)
}
if (!fh) {
- TSError("[%s] Unable to open config: %s. Will use the param as the path,
or %s if null\n", PLUGIN_NAME,
- config_holder->config_path, DEFAULT_URL_PATH);
+ TSNote("[%s] Unable to open config: %s. Will use the param as the path, or
%s if null\n", PLUGIN_NAME,
+ config_holder->config_path, DEFAULT_URL_PATH);
Review comment:
> the better option may be to just change the if to be:
> if (!fh && config_holder->config_path != NULL)
>
> Then it just gets shown if it couldnt open a file and a file was set
Yeah, that sounds reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
