ywkaras commented on code in PR #9486: URL: https://github.com/apache/trafficserver/pull/9486#discussion_r1131366869
########## iocore/net/QUICNetProcessor_quiche.cc: ########## @@ -90,8 +90,8 @@ QUICNetProcessor::start(int, size_t stacksize) } quiche_config_set_max_idle_timeout(this->_quiche_config, params->no_activity_timeout_in()); - quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, 16384); - quiche_config_set_max_send_udp_payload_size(this->_quiche_config, 16384); + quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, params->get_max_recv_udp_payload_size_in()); + quiche_config_set_max_send_udp_payload_size(this->_quiche_config, params->get_max_send_udp_payload_size_in()); Review Comment: Yes, that's what I thought. But I don't see how Quiche is allowing us to configure those values differently depending on whether the near end is the client or the server. If we can't, we only need two new config variables, not four. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
