maskit commented on code in PR #9486: URL: https://github.com/apache/trafficserver/pull/9486#discussion_r1131387511
########## iocore/net/QUICNetProcessor_quiche.cc: ########## @@ -90,8 +90,8 @@ QUICNetProcessor::start(int, size_t stacksize) } quiche_config_set_max_idle_timeout(this->_quiche_config, params->no_activity_timeout_in()); - quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, 16384); - quiche_config_set_max_send_udp_payload_size(this->_quiche_config, 16384); + quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, params->get_max_recv_udp_payload_size_in()); + quiche_config_set_max_send_udp_payload_size(this->_quiche_config, params->get_max_send_udp_payload_size_in()); Review Comment: Oh you mean different packet sizes for inbound connection and outbound connection? We'll need another quiche_config object for outbound connections. That is why we use `_in` settings here. We'll have similar code that use `_out` settings somewhere else in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
