bneradt commented on code in PR #9509:
URL: https://github.com/apache/trafficserver/pull/9509#discussion_r1131588336
##########
include/ts/apidefs.h.in:
##########
@@ -481,7 +481,7 @@ typedef enum {
// Putting the SSL hooks in the same enum space
// So both sets of hooks can be set by the same Hook function
- TS_SSL_FIRST_HOOK = 201,
+ TS_SSL_FIRST_HOOK,
Review Comment:
We talked about this on slack some. The tradeoff is this:
1. With a gap, we can add `TS_HTTP_*` values (hooks) without breaking
compatibility.
2. Without a gap, any new hook breaks compatibility and thus must be done
only on major releases.
If the decision is that we only add these hooks on major release, then we
don't need a gap in these values. I'm fine with that. I just want to make sure
that's understood.
---
Thus we can:
1. Remove the gap (as your original patch does) with the understanding that
hooks can only be add on major releases.
2. Make the gap a smaller value to avoid the performance issue, but still
keep the gap to allow for new hooks. Maybe leave a space of 5 values.
3. Refactor the enum into two enums so that the `TS_SSL*` hooks are in a
separate enum. But note that the comment above these enums says that keeping
them together in one enum is intentional.
I'm personally fine with any of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
