bneradt commented on code in PR #9509:
URL: https://github.com/apache/trafficserver/pull/9509#discussion_r1132549626
##########
include/ts/apidefs.h.in:
##########
@@ -481,7 +481,7 @@ typedef enum {
// Putting the SSL hooks in the same enum space
// So both sets of hooks can be set by the same Hook function
- TS_SSL_FIRST_HOOK = 201,
+ TS_SSL_FIRST_HOOK,
Review Comment:
After some discussion on slack, my vote would be to:
1. Merge in your PR as is and get rid of the gap.
2. Look into refactoring the enum to separate out these two types (`TS_HTTP`
and `TS_SSL`) so that the gap isn't needed. Let's keep that a separate PR if
that can be done reasonably cleanly enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
