SolidWallOfCode commented on code in PR #9531:
URL: https://github.com/apache/trafficserver/pull/9531#discussion_r1140299632
##########
lib/swoc/include/swoc/IPRange.h:
##########
@@ -1145,22 +1206,85 @@ class IPRangeSet
/// @return Number of ranges in the set.
size_t count() const;
+ bool empty() const;
+
/// Remove all addresses in the set.
void clear();
-protected:
- /// Empty struct to use for payload.
- /// This declares the struct and defines the singleton instance used.
- static inline constexpr struct Mark {
- using self_type = Mark;
- /// @internal @c IPSpace requires equality / inequality operators.
- /// These make all instance equal to each other.
- bool operator==(self_type const &that);
- bool operator!=(self_type const &that);
- } MARK{};
+ /// Constant iterator for iteration over ranges.
+ class const_iterator {
Review Comment:
My understanding is that inheriting from iterator tags is deprecated and
instead the types should be provided via `using`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
