ywkaras commented on code in PR #9531:
URL: https://github.com/apache/trafficserver/pull/9531#discussion_r1141030832
##########
lib/swoc/include/swoc/IPRange.h:
##########
@@ -1145,22 +1206,85 @@ class IPRangeSet
/// @return Number of ranges in the set.
size_t count() const;
+ bool empty() const;
+
/// Remove all addresses in the set.
void clear();
-protected:
- /// Empty struct to use for payload.
- /// This declares the struct and defines the singleton instance used.
- static inline constexpr struct Mark {
- using self_type = Mark;
- /// @internal @c IPSpace requires equality / inequality operators.
- /// These make all instance equal to each other.
- bool operator==(self_type const &that);
- bool operator!=(self_type const &that);
- } MARK{};
+ /// Constant iterator for iteration over ranges.
+ class const_iterator {
Review Comment:
So we're manually copying libswoc code and checking it into TS? I wonder if
we could implement this logic in the make file:
```
LIBSWOC_VERSION=yada
if [[ ! -d libswoc || ! -f libswoc/version || $LIBSWOC != $(cat
libswoc/version) ]] ; then
rm -rf libswoc
git clone something-something libswoc
echo $LIBSWOC_VERSION > libswoc/version # even better if libswoc alread
has this file
fi
```
and also be non-Damian and update .gitignore to ignore these source files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
