SolidWallOfCode commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1224742773
##########
iocore/net/SSLSNIConfig.cc:
##########
@@ -214,19 +205,24 @@ SNIConfigParams::get(std::string_view servername) const
return {nullptr, {}};
}
-int
+bool
SNIConfigParams::initialize()
{
std::string sni_filename =
RecConfigReadConfigPath("proxy.config.ssl.servername.filename");
+ return initialize(sni_filename);
+}
+bool
+SNIConfigParams::initialize(std::string const &sni_filename)
Review Comment:
Don't use `std::string const&` parameters, use `std::string_view`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
