[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9767: Filter SNI based on port

Fri, 09 Jun 2023 14:43:06 -0700 


SolidWallOfCode commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1224806416


##########
iocore/net/SSLSNIConfig.h:
##########
@@ -60,12 +65,19 @@ struct PcreFreer {
 struct NamedElement {
   NamedElement() {}
 
+  NamedElement(NamedElement const &other)            = delete;
+  NamedElement &operator=(NamedElement const &other) = delete;
   NamedElement(NamedElement &&other);
   NamedElement &operator=(NamedElement &&other);
+  ~NamedElement() = default;
 
   void set_glob_name(std::string name);
   void set_regex_name(const std::string &regex_name);
 
+  inline static constexpr in_port_t 
MAX_PORT_VALUE{std::numeric_limits<in_port_t>::max()};
+  using port_range_t = swoc::DiscreteRange<in_port_t>;

Review Comment:
   This shows up twice. Promote to "ts_ip.h"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to