JosiahWI commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1224781319
##########
iocore/net/SSLSNIConfig.cc:
##########
@@ -271,22 +267,22 @@ SNIConfig::reconfigure()
Debug("ssl", "Reload SNI file");
SNIConfigParams *params = new SNIConfigParams;
- int retStatus = params->initialize();
- if (!retStatus) {
+ bool retStatus = params->initialize();
+ if (retStatus) {
_configid = configProcessor.set(_configid, params);
prewarmManager.reconfigure();
} else {
delete params;
}
std::string sni_filename =
RecConfigReadConfigPath("proxy.config.ssl.servername.filename");
- if (!retStatus || TSSystemState::is_initializing()) {
+ if (retStatus || TSSystemState::is_initializing()) {
Note("%s finished loading", sni_filename.c_str());
} else {
Error("%s failed to load", sni_filename.c_str());
}
- return !retStatus;
+ return retStatus ? 1 : 0;
Review Comment:
Don't you think that's less clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
