JosiahWI commented on code in PR #9767:
URL: https://github.com/apache/trafficserver/pull/9767#discussion_r1224837495
##########
iocore/net/SSLSNIConfig.h:
##########
@@ -60,12 +65,19 @@ struct PcreFreer {
struct NamedElement {
NamedElement() {}
+ NamedElement(NamedElement const &other) = delete;
+ NamedElement &operator=(NamedElement const &other) = delete;
NamedElement(NamedElement &&other);
NamedElement &operator=(NamedElement &&other);
+ ~NamedElement() = default;
void set_glob_name(std::string name);
void set_regex_name(const std::string ®ex_name);
+ inline static constexpr in_port_t
MAX_PORT_VALUE{std::numeric_limits<in_port_t>::max()};
+ using port_range_t = swoc::DiscreteRange<in_port_t>;
Review Comment:
Maybe I'll sleep on it. I don't think there's any harm in DRYing it up, but
it's only in two places so my initial reaction was to wait until it happened in
a third place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
